Skip to content

refactor(lexer): re-order Token methods#11040

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-14-refactor_lexer_re-order_token_methods
May 15, 2025
Merged

refactor(lexer): re-order Token methods#11040
graphite-app[bot] merged 1 commit intomainfrom
05-14-refactor_lexer_re-order_token_methods

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 14, 2025

Pure refactor. Re-order Token's methods so getter and setter for each field are together, to make it easier to see how they correspond.

@github-actions github-actions bot added the A-parser Area - Parser label May 14, 2025
Copy link
Member Author

overlookmotel commented May 14, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 14, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 14, 2025 16:23
@codspeed-hq
Copy link

codspeed-hq bot commented May 14, 2025

CodSpeed Instrumentation Performance Report

Merging #11040 will not alter performance

Comparing 05-14-refactor_lexer_re-order_token_methods (47c624b) with main (c1e6c9b)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as draft May 14, 2025 16:44
@overlookmotel overlookmotel marked this pull request as ready for review May 14, 2025 19:33
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 15, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 15, 2025

Merge activity

Pure refactor. Re-order `Token`'s methods so getter and setter for each field are together, to make it easier to see how they correspond.
@graphite-app graphite-app bot force-pushed the 05-14-refactor_lexer_re-order_token_methods branch from 4647f8e to 47c624b Compare May 15, 2025 08:08
@graphite-app graphite-app bot merged commit 47c624b into main May 15, 2025
26 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 15, 2025
@graphite-app graphite-app bot deleted the 05-14-refactor_lexer_re-order_token_methods branch May 15, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant